wdi5 icon indicating copy to clipboard operation
wdi5 copied to clipboard

Published 20 hours ago • verified publisher icon ui5-community

fix: basic authentication (#615)

Open danielang opened this issue 1 year ago • 1 comments

This PR will fix #615 where the content of the .env file is simply put inside the URL. But instead it should be encoded before used in an URL.

danielang avatar May 17 '24 13:05 danielang

thanks for the fix, @danielang! and welcome to the wonderful world of wdi5 contributors 😸 the auth error is not attributed to your change → the CAP bookshop sample app needs to be fixed... ping @Siolto :)

vobu avatar May 17 '24 14:05 vobu

i'll pour this in anyhow in order not to hold up this fix due to the external CAP app dependency. thanks again for the contribution @danielang!

vobu avatar May 23 '24 07:05 vobu

@vobu Thank you as well - also for that kind welcome message 🙂

danielang avatar May 23 '24 08:05 danielang