vim-vixen icon indicating copy to clipboard operation
vim-vixen copied to clipboard

White Vim Vixen Console frame always visible at bottom of GitHub pages

Open asampal opened this issue 3 years ago • 64 comments
trafficstars

I'm opening this issue because:

  • I'm reporting a bug

Description

The Vim Vixen iframe with id vimvixen-console-frame is always showing, even when the extension is not being actively used, on GitHub pages. The content of the frame is empty/white.

Steps to Reproduce

-use Firefox Nightly

  • go to GitHub site
  • observe white area at the bottom of page

image

System configuration

  • Operating system: Windows 11
  • Firefox version: Nightly 102.0a1
  • Vim-Vixen version: 1.2.3

asampal avatar May 22 '22 18:05 asampal

Same here. It happens to the sites that applied the CSS color-scheme: dark.

vixen-ff

jackysee avatar May 24 '22 02:05 jackysee

Yep, also seeing this.

adudenamedruby avatar May 24 '22 13:05 adudenamedruby

Yup, this makes plugin unusable.

diimdeep avatar Jun 01 '22 17:06 diimdeep

+1. I'm currently working around this issue by using Custom CSS add-on. Would love to see it fixed.

Vis5 avatar Jun 04 '22 04:06 Vis5

Also for Nightly 103.0a1 on Plasma 5.24.5 Archlinux 5.18.2-arch1-1

Aiedails avatar Jun 11 '22 05:06 Aiedails

I also get the fat white bar at the bottom for many sites, but not all. I'm using FF Developer Edition 102.0b7 (64-bit). Seems the "vimvixen-console-frame" iframe is to blame...

SoundZero avatar Jun 15 '22 20:06 SoundZero

Just FYI, Firefox 102.0 hit Arch today, and this bug is present there. It's going to affect a lot more users now...

gi1242 avatar Jun 28 '22 22:06 gi1242

Just FYI, Firefox 102.0 hit Arch today, and this bug is present there. It's going to affect a lot more users now...

Exactly! Came here after the update.

People familiar with web development might open the dev tools in their browser and figure out the white bar being caused by this particular add-on, but others won't even be able to figure out what's causing the issue.

debnath-d avatar Jun 29 '22 06:06 debnath-d

+1. I'm currently working around this issue by using Custom CSS add-on. Would love to see it fixed.

@Vis5 what's your work around css?

jackysee avatar Jun 29 '22 07:06 jackysee

This workaround CSS works for me:

.vimvixen-console-frame {
  color-scheme: light !important;
}

majewsky avatar Jun 29 '22 09:06 majewsky

Yep just got this after Firefox updated to 102.0 on the AUR.

AsianKoala avatar Jun 29 '22 10:06 AsianKoala

@keyb0ardninja because you still need to use the console

jackysee avatar Jun 30 '22 03:06 jackysee

@keyb0ardninja because you still need to use the console

Just realized after commenting and deleted my comment before seeing yours 😅

debnath-d avatar Jun 30 '22 03:06 debnath-d

Same on https://scoop.sh/

InvisibleRain avatar Jul 02 '22 17:07 InvisibleRain

As a temporary workaround until this gets fixed, it's possible to disable Vim Vixen using the blacklist fuctionality in the extension's preferences:

"blacklist": [
    "github.com/*",
    "*.mozilla.org/*"
]

wraiford avatar Jul 04 '22 15:07 wraiford

This is not just an issue for GitHub pages, I get this on most web pages and tbh I'd rather use my mouse than disable dark mode.

pfr-dev avatar Jul 05 '22 23:07 pfr-dev

I think the issue has something to do with https://fvsch.com/transparent-iframes

If I add the following to src/console/index.html then it seems to make the iframe transparent again, however, it's briefly still white while the page is loading:

<meta name="color-scheme" content="light dark">

Edit: This seems to fix it for GitHub, but it adds a new dark box to the bottom of Twitter :angry: I still think the issue has something to do with how Firefox now handles the background color of iframes.

jessarcher avatar Jul 06 '22 00:07 jessarcher

@jessarcher Thanks for sharing that article, it would seem that is precicely the issue. As a Firefox user, and as the article suggests, I may be stuck until Firefox implements the opaque iframe logic.

pfr-dev avatar Jul 06 '22 00:07 pfr-dev

@jessarcher Thanks for sharing that article, it would seem that is precicely the issue. As a Firefox user, and as the article suggests, I may be stuck until Firefox implements the opaque iframe logic.

I think the problem is that Firefox has implemented the opaque iframe logic. So now, when the website has a CSS color-scheme that doesn't match the vim-vixen iframe (currently none) it gives it an opaque background.

I think the trick might be getting the iframe to detect the color-scheme of the parent page and then setting its own color-scheme to the same value so that Firefox will use a transparent background on the iframe.

jessarcher avatar Jul 06 '22 01:07 jessarcher

I think the trick might be getting the iframe to detect the color-scheme of the parent page and then setting its own color-scheme to the same value so that Firefox will use a transparent background on the iframe.

I have a PR with this solution at #1437. The white background was still briefly visible while the page is loading so I've also set the <iframe> height to 0px when the console is closed.

jessarcher avatar Jul 06 '22 11:07 jessarcher

Can anyone tell me how to install from github? This issue is really annoying.

noobaldrin avatar Jul 07 '22 02:07 noobaldrin

Can anyone tell me how to install from github? This issue is really annoying.

@noobaldrin The instructions to build and install a fork of this WebExtension with this issue fixed are at this comment. There is no direct link for a ready-made package with the fix. Thanks @jessarcher for authoring #1437.

if you're not comfortable with that, as an alternative you can temporarily install another Firefox add-on and apply the workaround suggested at this comment.

jman-schief avatar Jul 07 '22 07:07 jman-schief

if you're not comfortable with that, as an alternative you can temporarily install another Firefox add-on and apply the workaround suggested at this comment.

That's what I use as a workaround now. But why don't you point out what the "another Firefox add-on" is? I don't think it is very helpful without the add-on name. I'm using Stylus. If you don't want to specify an add-on, even pointing out "custom CSS add-on" would help.

ouuan avatar Jul 07 '22 07:07 ouuan

That's what I use as a workaround now. But why don't you point out what the "another Firefox add-on" is?

good point :) Any Firefox add-on able to override websites CSS is fine (such as Stylus). I randomly picked one and installed Custom CSS injector.

jman-schief avatar Jul 07 '22 08:07 jman-schief

Kudos and thanks to those fixing this! :rocket: Any ETA for a fix release to be published for those now comfortable with installing outside Mozilla Addons Store? looks quite convoluted... :disappointed: /cc @ueokande

pataquets avatar Jul 08 '22 22:07 pataquets

Another implementation of https://github.com/ueokande/vim-vixen/issues/1424#issuecomment-1169733896 fix.

  1. Download stylish
  2. Install this style
  3. Profit

xxSkyy avatar Jul 16 '22 16:07 xxSkyy

Another implementation of #1424 (comment) fix.

1. Download [stylish](https://addons.mozilla.org/en-US/firefox/addon/stylish/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search)

2. Install [this style](https://userstyles.org/styles/245566/vim-vixen-temporary-fix)

3. Profit

It literally doesn't fucking work.

Is there any useful solution? This seems to be a really easy thing to fix, wtf.

hrqmonteiro avatar Jul 17 '22 23:07 hrqmonteiro

Another implementation of #1424 (comment) fix.

1. Download [stylish](https://addons.mozilla.org/en-US/firefox/addon/stylish/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search)

2. Install [this style](https://userstyles.org/styles/245566/vim-vixen-temporary-fix)

3. Profit

It literally doesn't fucking work.

Is there any useful solution? This seems to be a really easy thing to fix, wtf.

There is no reason to be rude about it that won't get you anywhere in life.

nonetrix avatar Jul 18 '22 05:07 nonetrix

This workaround CSS works for me:

.vimvixen-console-frame {
  color-scheme: light !important;
}

fixed it for me thanks

nonetrix avatar Jul 18 '22 05:07 nonetrix

I dumped the fix into a UserScript. I use Violentmonkey so I'm not sure if this UserScript works in Grease Monkey. ~Works OK for a workaround except that the box is visible for that split second due to rendering.~

// ==UserScript==
// @name        Vim Vixen Vix
// @namespace   Violentmonkey Scripts
// @match       *://*/*
// @grant       GM_addStyle
// @run-at      document-start
// @version     1.1
// @author      -
// @description Fixes white bottom bar on dark themed web pages when using Vim Vixen
// ==/UserScript==
GM_addStyle(".vimvixen-console-frame {height: 0px; color-scheme: light !important;}");

Works well now. Updated the Userscript, thanks @aleksandrs-ledovskis

rtrajano avatar Jul 21 '22 18:07 rtrajano