feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Provide an onClose callback

Open mrgzi opened this issue 3 years ago • 5 comments
trafficstars

Banner bottom ads cover the send button, therefore we have to hide the banner before we show feedback. But there is another issue that appears, we don't know if the user canceled the feedback. In this case, we should provide an onClose callback function.

mrgzi avatar Apr 17 '22 17:04 mrgzi

Can you provide example code? Without more information I can't do anything about it. Also please use the issue template.

ueman avatar Apr 17 '22 18:04 ueman

If you show the banner in any network, you can see that the banner stays above the feedback widget.

Screen Shot 2022-04-18 at 01 27 32

mrgzi avatar Apr 17 '22 22:04 mrgzi

How are you displaying your banner ad? I'm not getting this issue using https://pub.dev/packages/google_mobile_ads

caseycrogers avatar May 09 '22 20:05 caseycrogers

Adding another use case:

In my app, I am showing financial information. Therefore I am giving the user an option to hide the monetary values. If the user exists the feedback mode, I want to revert back to the previous viewing mode. I can revert back during onSubmit, but I have no chance to revert back when the user cancels the feedback.

buchen avatar Sep 14 '23 20:09 buchen

And for other looking for this - maybe listening on the changeNotifier could work for you

final betterFeedback = BetterFeedback.of(context);
void listener() => print('status is ${betterFeedback.isVisible}');
betterFeedback.addListener(listener);

buchen avatar Sep 14 '23 21:09 buchen