John-John Tedro

> I assume that is in bytes? An increase of ~40KB is a significant increase in binary size Up to you to decide. I get something like 10kb variability between...

> What about hash collisions? The std implementation of `HashMap` has special code for dealing with hash collisions which can be seen here: https://docs.rs/hashbrown/latest/src/hashbrown/raw/mod.rs.html#822 Hash collisions in a HashMap are...

It's unclear to me how you run the full suite of benchmarks using that action since it looks rather complicated. Is there a simplified one we can run or can...

Switched to criterion, since it's way harder to just selectively disable the default benches. @WorldSEnder If I read you correct you personally wanted to run the webdriver benchmarks?

> Can this benefit from niche optimization? Specifically, we use Option a few times in the code. Can we reserve one hash value as a niche such that size_of:: ==...

minrust constraint I didn't foresee. Not a big deal so will fix: https://github.com/tokio-rs/tokio/runs/5235296039?check_suite_focus=true

To resolve the lint failure in https://github.com/tokio-rs/tokio/runs/5236195058?check_suite_focus=true I believe we'd have to do something similar as in #4176 which requires a bit more effort! I'll take a look at later...

Hm. So after pondering the implementation for a bit I have a couple of thoughts. What is desirable to me would be to perform the following transformation *rather* than what...

Thanks for context! So arguments could be supported with a bit of mangling (the tricky aspect is patterns). `self` however could not (as you say), so the proposed breakage could...

Also worth noting that there are some more insidious examples of poor diagnostics today: Thanks to a fairly confused instance of type inference we've convinced rustc to say both of...