John-John Tedro

If you want to play around with the problem space, [here's a playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=aa512d7482563b469f16beac4f0bb6df) I put together. This is [another playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=6a44f1eeeda70b3bf3ceab0a9100ce4b) showing how we currently solve it with references.

> Since you already use a macro (declarative) to generate these impls, what is the cost of repeating it for a few more parameters? Is it build time due to...

Implementation looks good, documentation-wise I'd recommend copying and adapting the [`std::process` documentation](https://doc.rust-lang.org/std/process/index.html). Can you make sure to add a Copyright notice to `modules.rs` since we've copied a fair bit of...

Yeah, that's fine. Just add all the copyright notices one after another. > I'm also not sure how you handle tests for things like this. Also realized I didn't mention...

As for actual tests we run, I think you'll have to build proper integration tests (in e.g. `crates/rune/tests`) using [`tempfile`](https://docs.rs/tempfile) for setting up temporary directories. Might also be time to...

> I wish you quick recovery (or whatever the idiomatic phrase in English is for this) Tack tack

I've extended the module with more documentation (copied from Tokio) and followed a newer convention of marking most methods as `keep`. As for testing, it would be nice to see...

That's perfectly OK!

FYI, this seems like the same issue in rune-rs/rune#601 I'm mentioning it here so you can consider the same remedy which is to bind local references using HRTBs.

This is the relevant commit: https://github.com/rune-rs/rune/pull/601/commits/ce81e690dc7e2efaf852408218f55fb4337e0ada Here's a playground which might make it clearer: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=0edc3aa181f03772f7c48a9c41985630 Of particular interest is an implementation like `where T: Fn(&A), A: ?Sized + FromValueRef2`, which...