John-John Tedro

Results 376 comments of John-John Tedro

Right. Thanks for the clarity. So that is what I gathered from reading the implementation as well. The only extent I expect the table to be exception safe is that...

We currently release tokens once an acquire future is dropped, so in a way this is already implemented but perhaps not to the way you want it. Do you have...

Ah, so you're just looking for a way to manually add permits to the rate limiter? That's should be fairly easy to implement. It's essentially what the core task does....

I don't mind. I can't remember why they're copy, so if you want to give it a stab, please document in case you come up against any problems.

Ah yeah. That's clearly also an issue for SetStorage, since for simple enums it's implemented as a boolean array. Or as a bitset if [`#[key(bitset)]` is specified](https://docs.rs/fixed-map/latest/fixed_map/derive.Key.html#keybitset). Tricky! I'm not...

So either it's a [tag type which is not supported](https://github.com/udoprog/c10t/blob/3874582abaf3a9e71da27d70c8786176563f4f2c/src/nbt/nbt.hpp#L238) because c10t is rather outdated, or the region file is corrupted. I'm not maintaining this project actively, but I'll review...

So we don't have support for `TAG_Long_Array`. See: https://minecraft.gamepedia.com/NBT_format

Hey, Guessing the block format has changed or new blocks added? I'm not an active Minecraft player anymore. But I'd be happy to take care of incoming patches and make...

@evildeeds awesome. thanks for checking.

hm, it's very much possible to produce a non 24 bit (8 bit per channel) and go for 16 bit (4 bit per channel), but the color ranges will be...