xng-breadcrumb icon indicating copy to clipboard operation
xng-breadcrumb copied to clipboard

Published 20 hours ago • verified publisher icon udayvunnam

feat: make routeSnapshot data available in breadcrumb function

Open udayvunnam opened this issue 3 years ago • 13 comments

What is this PR about

  • make routeSnapshot data available in breadcrumb function
  • use NavigationEnd instead of GuardCheck

PR Checklist

Please check if your PR fulfils the following requirements:

  • [x] The commit message follows the guidelines
  • [x] Tests for the changes have been added (for bug fixes/features)
  • [x] Docs have been added/updated (for bug fixes/features)

udayvunnam avatar Mar 27 '22 04:03 udayvunnam

Hello 👋 @udayvunnam
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

github-actions[bot] avatar Mar 27 '22 04:03 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 16:07 stale[bot]

Hello!

There are still plans to merge the this PR to make activatedRouteSnapshot data available in breadcrumb function?

luizagabriela avatar Sep 28 '22 13:09 luizagabriela

Yes, @luizagabriela

udayvunnam avatar Oct 03 '22 00:10 udayvunnam

I'm glad to hear that this functionality will be integrated, it will help us. Do you know when the changes will be merge?

luizagabriela avatar Oct 05 '22 09:10 luizagabriela

Hello Do you know when this PR will be merged?

RalucaCorb avatar Nov 08 '22 08:11 RalucaCorb

I will try to get this fixed and merged over the weekend

udayvunnam avatar Nov 08 '22 15:11 udayvunnam

Great! Thanks.

RalucaCorb avatar Nov 09 '22 05:11 RalucaCorb

Hi! Do you know when this PR will be merged?

luizagabriela avatar Jan 06 '23 13:01 luizagabriela

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 08 '23 23:05 stale[bot]

Hi @udayvunnam, any plans to merge this soon? Thanks!

miroslavgrozdanovski avatar Aug 07 '23 09:08 miroslavgrozdanovski

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 08:12 stale[bot]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 29 '24 05:03 github-actions[bot]