xng-breadcrumb icon indicating copy to clipboard operation
xng-breadcrumb copied to clipboard

Breadcrumb link disappears on CanDeactivate guard check when the route has a resolver. Breadcrumb loads before the resolver promise completes.

Open udayvunnam opened this issue 3 years ago • 8 comments

@udayvunnam - The feature is failing in another scenario i.e. when the route has a resolver. Breadcrumb loads before the resolver promise completes. Also, I saw you have added a new filter for GuardChecksEnd in the breadcrumb service. This is breaking the earlier guard check fix which was added. Now even if "cancel" button is clicked, the breadcrumb link disappears.

Instead of the below - line 68 .pipe(filter((event) => event instanceof GuardsCheckEnd))

replace with NavigationEnd .pipe(filter((event) => event instanceof NavigationEnd))

remove "&& event.shouldActivate" from line 76

This should resolve both GuardCheck and Resolver issues.

Originally posted by @nakash2050 in https://github.com/udayvunnam/xng-breadcrumb/discussions/111#discussioncomment-2130446

udayvunnam avatar Feb 09 '22 02:02 udayvunnam

Hello 👋 @udayvunnam
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

github-actions[bot] avatar Feb 09 '22 02:02 github-actions[bot]

Hi, @udayvunnam , I too am seeing this issue. Would it be possible to get a timeframe for this fix? Thanks in advance for your time and attention.

hugo-azevedo avatar Mar 01 '22 15:03 hugo-azevedo

@hugo-azevedo currently I am occupied with my work, I can work on this in the next two weeks. PR is always welcome if you wish to contribute.

udayvunnam avatar Mar 02 '22 03:03 udayvunnam

^^ @hugo-azevedo please check https://github.com/udayvunnam/xng-breadcrumb/discussions/111#discussioncomment-2445006

udayvunnam avatar Mar 27 '22 03:03 udayvunnam

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 30 '22 16:07 stale[bot]

not stale

udayvunnam avatar Aug 03 '22 05:08 udayvunnam

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 03 '22 14:12 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '23 15:10 stale[bot]