xng-breadcrumb
xng-breadcrumb copied to clipboard
Breadcrumb link disappears on CanDeactivate guard check when the route has a resolver. Breadcrumb loads before the resolver promise completes.
@udayvunnam - The feature is failing in another scenario i.e. when the route has a resolver. Breadcrumb loads before the resolver promise completes. Also, I saw you have added a new filter for GuardChecksEnd in the breadcrumb service. This is breaking the earlier guard check fix which was added. Now even if "cancel" button is clicked, the breadcrumb link disappears.
Instead of the below - line 68 .pipe(filter((event) => event instanceof GuardsCheckEnd))
replace with NavigationEnd .pipe(filter((event) => event instanceof NavigationEnd))
remove "&& event.shouldActivate" from line 76
This should resolve both GuardCheck and Resolver issues.
Originally posted by @nakash2050 in https://github.com/udayvunnam/xng-breadcrumb/discussions/111#discussioncomment-2130446
Hello 👋 @udayvunnam
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide
Hi, @udayvunnam , I too am seeing this issue. Would it be possible to get a timeframe for this fix? Thanks in advance for your time and attention.
@hugo-azevedo currently I am occupied with my work, I can work on this in the next two weeks. PR is always welcome if you wish to contribute.
^^ @hugo-azevedo please check https://github.com/udayvunnam/xng-breadcrumb/discussions/111#discussioncomment-2445006
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
not stale
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.