orbit icon indicating copy to clipboard operation
orbit copied to clipboard

Add inheritance of ABC from the abc package for abstract classes

Open FreeRealEstate221 opened this issue 3 years ago • 1 comments
trafficstars

For the abstract classes like forecaster or base_estimator, we could inherit the ABC class from the abc package so that 1) we could prevent abstract classes from being instantiated; 2) we don't need to raise NotImplementedError manually each time

You could find further explanation in the stackoverflow here: https://stackoverflow.com/questions/56008847/when-should-one-inherit-from-abc

FreeRealEstate221 avatar Dec 15 '21 01:12 FreeRealEstate221

This should reduce the work to implement raise implemented error to all functions. @wangzhishi

edwinnglabs avatar Dec 15 '21 04:12 edwinnglabs