h3 icon indicating copy to clipboard operation
h3 copied to clipboard

constants.h and exported headers

Open kreuzerkrieg opened this issue 5 years ago • 3 comments

Hi, I'm trying to use the MAX_H3_RES. It is defined in constants.h but this header isnt exported when the package is installed. Is it a bug or I'm just missing something?

kreuzerkrieg avatar May 01 '20 18:05 kreuzerkrieg

Originally the thought was only h3api.h would be needed by a user of the library since that's the external API. We probably want to consider this something to improve and have some way for users to include the other headers in order to access these macros. Possibly install the other headers like h3/internal/constants.h to indicate they're internal?

isaacbrodsky avatar May 01 '20 18:05 isaacbrodsky

it depends. do you consider using these constants as something legitimate user would use? If yes, no need for internal, on the other hand if you consider such a behaviour as "hackish" internal should be used

kreuzerkrieg avatar May 01 '20 18:05 kreuzerkrieg

Somewhat related #277 .

zachasme avatar May 11 '20 09:05 zachasme