mock icon indicating copy to clipboard operation
mock copied to clipboard

Support batch mode for better performance on large codebases

Open kszafran opened this issue 7 months ago • 4 comments

See https://github.com/uber-go/mock/issues/245 for the motivation behind this PR.

I split this PR into a series of self-contained commits, so that it's easier to review the changes commit-by-commit.

Summary by CodeRabbit

  • Documentation

    • Added a "Batch mode" section explaining how to use a YAML configuration file to generate mocks for multiple packages at once.
  • New Features

    • Introduced batch processing for mock generation, enabling simultaneous handling of multiple packages with enhanced configuration options and streamlined command-line flag management.

kszafran avatar Apr 10 '25 13:04 kszafran

Walkthrough

This update introduces a new “Batch mode” for the mockgen tool. The documentation now explains how to configure batch processing using a YAML file with both global and package-specific flags. The code base has been refactored to support this feature by adding new constants, helper functions, and data structures for configuration handling. In addition, method signatures in the generator and tests have been updated to incorporate the new batch logic. The package parsing logic has also been modified to handle multiple packages concurrently.

Changes

File(s) Change Summary
README.md Added a new "Batch mode" section that documents how to generate mocks for multiple packages simultaneously using a YAML configuration file.
go.mod Updated dependency management for gopkg.in/yaml.v3: added as a direct dependency and removed it from the indirect dependencies list.
mockgen/mockgen.go, mockgen/mockgen_test.go Introduced new constants and a helper function prepareTargets to parse the YAML file. Added new types (e.g., Batch, Target, Flags, genTarget) for batch processing. Updated method signatures including Generate and GenerateMockInterface (adding an extra boolean flag) to streamline processing of batch configuration. Test invocation was updated accordingly.
mockgen/package_mode.go Refactored package parsing to support multiple packages by removing the pkgName field, adding the parsePackages method, and modifying methods for alias replacement and package loading to accept multiple packages.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant M as mockgen Main
    participant PT as prepareTargets
    participant GT as generateTarget
    participant G as generator

    U->>M: Run mockgen with YAML config
    M->>PT: Process YAML to extract batch targets
    PT-->>M: Return list of genTarget objects
    loop For each target
        M->>GT: Call generateTarget(target)
        GT->>G: Invoke Generate(target) / GenerateMockInterface(target)
        G-->>GT: Return generated mock
    end

Poem

Oh, I hopped to spread the news today,
Batch mode is here in a brilliant array!
YAML files dance to set mocks free,
Flags and targets unite in harmony.
I, a happy rabbit, cheer with delight—
CodeRabbit leaps, making mock generation bright!

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 10 '25 13:04 coderabbitai[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 10 '25 13:04 CLAassistant

@sywhang, @JacobOaks, @tchung1118, can you take a look at this? This could be a really big improvement.

ArujReis avatar May 11 '25 04:05 ArujReis

Please also take a look at my comment here: https://github.com/uber-go/mock/issues/245#issuecomment-2832577637 for an alternative/supplementary approach.

kszafran avatar May 11 '25 08:05 kszafran