opentracing-python-instrumentation icon indicating copy to clipboard operation
opentracing-python-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon uber-common

Add support to Tornado 6

Open nicholasamorim opened this issue 6 years ago • 4 comments

Tornado 6 does not contain the StackContext used in the current implementation.

How could we support Tornado 6? Should one of the already-implemented ScopeManagers be used?

Should the contextvars module be used? That would limit the usage to Python 3.7+ though.

nicholasamorim avatar May 22 '19 19:05 nicholasamorim

Because Tornado 6 fully asyncio-based framework, I think it's better to use AsyncioScopeManager. You can see this PoC about the problem https://github.com/opentracing/opentracing-python/pull/118

condorcet avatar May 24 '19 14:05 condorcet

Any progress?

Alessandro-Barbieri avatar Oct 26 '21 00:10 Alessandro-Barbieri

Any progress?

matej14086 avatar Feb 22 '23 13:02 matej14086

See https://github.com/uber-common/opentracing-python-instrumentation/issues/118

yurishkuro avatar Feb 22 '23 14:02 yurishkuro