google-charts-node icon indicating copy to clipboard operation
google-charts-node copied to clipboard

puppeteer launch headless new

Open scottg369 opened this issue 2 years ago • 1 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/google-charts-node/lib/render.js b/node_modules/google-charts-node/lib/render.js
index 0551607..21f4989 100644
--- a/node_modules/google-charts-node/lib/render.js
+++ b/node_modules/google-charts-node/lib/render.js
@@ -20,7 +20,7 @@ async function renderGoogleChart(contentRaw, optsRaw) {
     optsRaw || {},
   );
 
-  const browser = await puppeteer.launch(opts.puppeteerOptions);
+  const browser = await puppeteer.launch({headless: 'new'});
 
   const page = await browser.newPage();
   page.setDefaultTimeout(RENDER_TIMEOUT_MS);

This issue body was partially generated by patch-package.

scottg369 avatar Jul 26 '23 05:07 scottg369

Hi Scott,

This behavior is supported via puppeteerOptions. For example:

const image = await GoogleChartsNode.render(drawChart, {
  width: 400,
  height: 300,
  puppeteerOptions: {
    headless: 'new'
  }
});

typpo avatar Jul 26 '23 05:07 typpo