typeorm-typedi-extensions icon indicating copy to clipboard operation
typeorm-typedi-extensions copied to clipboard

Set ConnectionManager as global in Container

Open MWhite-22 opened this issue 4 years ago • 8 comments

Fixes scoped containerInstance.get requests for ConnectionManager, which was previously creating a cloned ConnectionManager via new ConnectionManager(), thereby removing all prior connection information.

MWhite-22 avatar Jun 30 '21 13:06 MWhite-22

Checking in on any sort of acknowledgement here from any maintainers. It’s only a single line change in the package.

Detailed comments are in #51

@glen-84 @slavafomin @pleerock @NoNameProvided

MWhite-22 avatar Jul 06 '21 02:07 MWhite-22

I'm not a maintainer.

glen-84 avatar Jul 06 '21 06:07 glen-84

@pleerock @NoNameProvided

Checking in again.

MWhite-22 avatar Jul 15 '21 15:07 MWhite-22

@pleerock @NoNameProvided

I hate to keep pinging you both, but when trying to dockerize, the non-global container issue is a real bummer.

MWhite-22 avatar Aug 05 '21 18:08 MWhite-22

@NoNameProvided any chance to approve and release a new patch for this package? Without it it breaks scoped comtainers.

Abdizriel avatar Sep 30 '21 16:09 Abdizriel

bumping this again

MWhite-22 avatar May 09 '22 19:05 MWhite-22

Bumping this to the top of (hopefully) someones review queue

MWhite-22 avatar Jun 17 '22 18:06 MWhite-22

Welp, about time to bump this one up again...

MWhite-22 avatar Nov 23 '22 18:11 MWhite-22