typedi icon indicating copy to clipboard operation
typedi copied to clipboard
verified publisher icon typestack

Fix documentation on using transient services

Open Ryman opened this issue 3 years ago • 2 comments

cc https://github.com/typestack/typedi/issues/51

Description

The documentation for setting up transient services was incorrect and references a scope property which isn't accepted by the Typescript compiler.

Checklist

  • [x] the pull request title describes what this PR does (not a vague title like Update index.md)
  • [x] the pull request targets the default branch of the repository (develop)
  • [x] the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [x] tests are added for the changes I made (if any source code was modified)
  • [x] documentation added or updated
  • [ ] I have run the project locally and verified that there are no errors

Ryman avatar Aug 30 '22 18:08 Ryman

@attilaorosz (pinging you as you're the first human in the review history of master) Can you take a look at this?

Ryman avatar Jul 31 '23 16:07 Ryman

The problem is that the latest dev branch has it and the documentation should be aligned with that. Unfortunately it is not released.

@NoNameProvided any plans on a new release?

attilaorosz avatar Jul 31 '23 16:07 attilaorosz