Repo: `lint-fix` script is broken

[fisker]

trafficstars

Suggestion

I don't think pass --fix to

https://github.com/typescript-eslint/typescript-eslint/blob/e57126a23e3f9b0ec67665d47e37a429d7755753/package.json#L41

is correct.

Additional Info

No response

[JoshuaKGoldberg]

Nice spot, thanks 🙂

[cseas]

Hi! I tried looking into this. It looks like the lint script isn't configured properly either. The lint command at the root package.json runs the below Nx target:

https://github.com/typescript-eslint/typescript-eslint/blob/main/package.json#L155-L156

This means the root lint script isn't linting any code inside packages. Is this intended?

I tried removing that packages filter and then got one ESLint error inside the packages directory. This is present on the main branch so I'm guessing the lint workflow isn't catching this either.

The lint-fix script has changed since this issue was reported and now seems to be passing the --fix flag correctly. But I believe the behaviour of the lint script itself has now changed (modified in #11226).

Are the root lint and lint-fix scripts supposed to lint/fix the entire project or everything except packages?

[github-actions[bot]]

Uh oh! @cseas, at least one image you shared is missing helpful alt text. Check https://github.com/typescript-eslint/typescript-eslint/issues/11201#issuecomment-2958835259 to fix the following violations:

• Images should have meaningful alternative text (alt text) at line 10

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

[cseas]

Related: https://github.com/typescript-eslint/typescript-eslint/issues/11229

[JoshuaKGoldberg]

I believe this was fixed by #11226. 👍