grackle
grackle copied to clipboard
Added support for Oracle via Doobie
Work in progress ...
Codecov Report
Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.
Project coverage is 75.89%. Comparing base (
6bd6ba9) to head (9bd0b28). Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 75.60% 75.89% +0.29%
==========================================
Files 32 34 +2
Lines 5030 5091 +61
Branches 1094 1091 -3
==========================================
+ Hits 3803 3864 +61
Misses 1227 1227
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Oracle? Wow, my condolences.
@tpolecat the biggest job turned out to be rejigging the organisation of the various modules, and reworking the way docker is used in the tests/demo (the Oracle image takes way too long to startup and shutdown to run that cycle once for each suite).
I imagine you'll want to avert your gaze from the Oracle specifics, but I'd welcome your feedback on the reorg, the docker usage and also this change in the skunk module (currently a Session resource is use'd once per-fetch, which is probably harmless in the presence of a connection pool, but I think not ideal).
This will stay as WIP until the accompanying SQL Server module lands.
Superseded by #675.