grackle icon indicating copy to clipboard operation
grackle copied to clipboard

Fix for polymorphic fields in SqlMapping

Open milessabin opened this issue 1 year ago • 1 comments

milessabin avatar Jun 11 '24 17:06 milessabin

Can you summarize what this change does? It looks like it's causing all of our discriminator predicates to fail.

tpolecat avatar Aug 19 '24 15:08 tpolecat

@tpolecat thanks for the update!

milessabin avatar Sep 07 '24 14:09 milessabin

Rebased.

milessabin avatar Sep 07 '24 14:09 milessabin

Codecov Report

Attention: Patch coverage is 86.13861% with 14 lines in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (3a6b7b8) to head (a1dbc5f). Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
modules/sql/shared/src/main/scala/SqlMapping.scala 88.00% 6 Missing :warning:
modules/core/src/main/scala/cursor.scala 0.00% 2 Missing :warning:
modules/core/src/main/scala/mapping.scala 89.47% 2 Missing :warning:
modules/circe/src/main/scala/circemapping.scala 80.00% 1 Missing :warning:
modules/core/src/main/scala/queryinterpreter.scala 93.75% 1 Missing :warning:
modules/core/src/main/scala/valuemapping.scala 80.00% 1 Missing :warning:
...les/generic/src/main/scala-2/genericmapping2.scala 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   74.22%   75.59%   +1.36%     
==========================================
  Files          32       32              
  Lines        4609     5064     +455     
  Branches     1025     1099      +74     
==========================================
+ Hits         3421     3828     +407     
- Misses       1188     1236      +48     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 07 '24 15:09 codecov-commenter