cats
cats copied to clipboard
Optimize Alternative (part 3): add prependK/appendK specializations for Cats NE wrappers
Adds optimized specializations for the new prependK/appendK methods introduced in the initial PR (#4014).
Previous PR:
- add specializations for
NonEmptyAlternativeinstances for Scala library collections #4052.
Subsequent PR:
- add specializations for Cats monad transformers.
Looking pretty good, but we should wait until MiMa is fixed in https://github.com/typelevel/cats/pull/4063.
Hi @armanbilge , just to confirm with you: is this PR still blocked by #4063 ?
Ah, this one has been sitting for a while, sorry!
IIRC this PR made some changes to type signatures that looked like they could cause the same bincompat issues that we had with the Id instances for Scala 3. I could be wrong though. So, I think better to play it safe.
I would now say this PR is blocked by https://github.com/typelevel/cats/issues/4143 which will enable MiMa for Scala 3 and supersede https://github.com/typelevel/cats/pull/4063. I hope to work on that this weekend.
@satorg I believe I owe you a review here, also do you mind fixing up the conflicts 😅
Yeah, I'm keeping eye on it.. I will be happy to resume working on this.. Just a lil'bit busy on my work project now – it is approaching a deadline so quite difficult to put aside time for anything else.
@armanbilge here it is, finally :)
That's great, thanks for all your work on this! I'm currently buried working on https://github.com/typelevel/cats-effect/pull/3138#issuecomment-1242470003 but I promise we will get this into 2.9.0.
Bumped up deprecation versions to "2.9.0".