cats-effect icon indicating copy to clipboard operation
cats-effect copied to clipboard

Update GraalVM from 17 to 21

Open mzuehlke opened this issue 1 year ago • 5 comments
trafficstars

GraalVM is no longer available under the free license: https://github.com/graalvm/setup-graalvm#notes-on-oracle-graalvm-for-jdk-17

sbt-typelevel already did the same: https://github.com/typelevel/sbt-typelevel/pull/763

mzuehlke avatar Oct 21 '24 21:10 mzuehlke

I guess the Scala versions in this branch are way too old

mzuehlke avatar Oct 21 '24 21:10 mzuehlke

Oh darn, actually we can't use GraalVM 21 here at all, because this branch is pinned to Scala 3.2 and we can't do anything about that.

armanbilge avatar Oct 21 '24 21:10 armanbilge

So dropping GraalVM from this branch seems to be the only option, or follow the not recommended path https://github.com/graalvm/setup-graalvm#notes-on-oracle-graalvm-for-jdk-17 and use exactly java-version: '17.0.12'

mzuehlke avatar Oct 21 '24 21:10 mzuehlke

use exactly java-version: '17.0.12'

Oh, good idea. Let's do that. This branch just needs to limp a little longer.

armanbilge avatar Oct 21 '24 21:10 armanbilge

The way sbt-typelevel uses the version number leads to an invalid workflow file 😢

Invalid workflow file: .github/workflows/ci.yml#L206 The workflow is not valid. .github/workflows/ci.yml (Line: 206, Col: 20): Unexpected symbol: '0.12.outputs.jdkFile'. Located at position 32 within expression: steps.download-java-graalvm-17.0.12.outputs.jdkFile .github/workflows/ci.yml (Line: 404, Col: 20): Unexpected symbol: '0.12.outputs.jdkFile'. Located at position 32 within expression: steps.download-java-graalvm-17.0.12.outputs.jdkFile

mzuehlke avatar Oct 22 '24 05:10 mzuehlke

I would propose to remove GraalVM from the build matrix then.

mzuehlke avatar Oct 22 '24 18:10 mzuehlke

The way sbt-typelevel uses the version number leads to an invalid workflow file 😢

Crap. We should fix this bug in sbt-tl.

That probably won't help us here though. We might just have to remove GraalVM.

armanbilge avatar Oct 23 '24 01:10 armanbilge

Removing GraalVM from 3.5 feels like the right short-term strategy. We really need to get 3.6 out the door.

djspiewak avatar Oct 25 '24 13:10 djspiewak

Note to self: when we do our next 3.5 release, we need to make sure to revert this commit specifically.

djspiewak avatar Oct 25 '24 16:10 djspiewak

Note to self: when we do our next 3.5 release, we need to make sure to revert this commit specifically.

What do you want to revert ? The problem is that you can no longer download GraalVM 17 without a paid license. Specifying the latest patch version that is still available isn't working with sbt-typelevel-github-action. And excape would be to "fix the GHA ci.yml by hand and disable the usage of githubWorkflowCheck.

mzuehlke avatar Oct 25 '24 20:10 mzuehlke