cats-effect icon indicating copy to clipboard operation
cats-effect copied to clipboard

Published 20 hours ago • verified publisher icon typelevel

Accept `Duration` for all time-based combinators

Open armanbilge opened this issue 3 years ago • 1 comments

Follow-up to https://github.com/typelevel/cats-effect/pull/2954.

armanbilge avatar Jul 13 '22 21:07 armanbilge

Something I'm leery about is that these changes introduce a lot of branches that aren't currently tested by our laws which I think work in terms of FiniteDuration. We should change the laws as well, and if not then at least add specific test coverage for this.

armanbilge avatar Jul 17 '22 19:07 armanbilge

This seems good if we can get it to build. :-)

Heh, I was waiting for a positive sign before continuing :) I'm on it!

armanbilge avatar Sep 20 '22 22:09 armanbilge