typedoc-plugin-markdown icon indicating copy to clipboard operation
typedoc-plugin-markdown copied to clipboard

Comments missing from .md

Open omfgnuts opened this issue 3 years ago • 8 comments

Heyo!

I'm using your plugin to generate .md files, so I can later convert them to asciidoc files, everything works except for getting code comments into .md.

HTML with default theme gets comments with no issues, but it looks like something strips them when using typedoc-plugin-markdown.

image image

What am I missing?

omfgnuts avatar Aug 04 '22 16:08 omfgnuts

not sure - i couldn't replicate on initial test - will dig into to it to see why this might happen in your use-case.

tgreyuk avatar Aug 04 '22 22:08 tgreyuk

not sure - i couldn't replicate on initial test - will dig into to it to see why this might happen in your use-case.

If you'll have some time to spare on this issue:

If it helps, I'm trying to markdownify nativescript's docs here: https://github.com/NativeScript/NativeScript

command to build docs is nx run core-api-docs:build

What i should note, you'll need to remove "../../packages/core/**/*.ts" from excludes in /NativeScript/tools/scripts/tsconfig.typedoc.json and it should build just fine

omfgnuts avatar Aug 04 '22 23:08 omfgnuts

Which versions of typedoc and typedoc-plugin-markdown are used? Not all versions are compatible with each other due to changes in minor versions of typedoc. I observed some data missing when trying mutually incompatible versions. This might also mean some breaking change was not caught up if both versions are most recent.

KillyMXI avatar Aug 05 '22 11:08 KillyMXI

Which versions of typedoc and typedoc-plugin-markdown are used? Not all versions are compatible with each other due to changes in minor versions of typedoc. I observed some data missing when trying mutually incompatible versions. This might also mean some breaking change was not caught up if both versions are most recent.

Damn. You're right, I even forced new typedoc version in package.json but forgot to re-run npm -i, sorry to waste your time, but it helped a lot!

Now it gathers those comments no problemo :3

While you're here, (sorry!) what's the optimal way to fix following markup (or at least avoid writing regex or a script that removes extra free line and move link to the "Defined in" header:

image

omfgnuts avatar Aug 05 '22 12:08 omfgnuts

While you're here, (sorry!) what's the optimal way to fix following markup (or at least avoid writing regex or a script that removes extra free line and move link to the "Defined in" header:

Currently working on making the templates easily customisable - not too far off.

tgreyuk avatar Aug 07 '22 21:08 tgreyuk

@omfgnuts could you please share which versions worked for you?

I've had same issue (documented here) but guessing this may be the problem...

chrisui avatar Aug 16 '22 17:08 chrisui

Updating solved for us too.

chrisui avatar Aug 16 '22 18:08 chrisui

Updating solved for us too.

Facing the same issue. Could you share the specific versions of the two packages that worked for you please?

eswarclynn avatar Sep 28 '22 13:09 eswarclynn