ember-cli-typescript icon indicating copy to clipboard operation
ember-cli-typescript copied to clipboard

v6 release: the last major?

Open NullVoxPopuli opened this issue 2 years ago • 6 comments

Remaining todos here https://github.com/typed-ember/ember-cli-typescript/issues/1568

(most of this is documentation tho, and non-breaking)


Keeping track of changes here for the changelog, tho it does seem like release-it is set up, so this'll all probably be automatic:

Breaking

  • https://github.com/typed-ember/ember-cli-typescript/pull/1570

Enhancements

  • https://github.com/typed-ember/ember-cli-typescript/pull/1569
  • https://github.com/typed-ember/ember-cli-typescript/pull/1562
  • https://github.com/typed-ember/ember-cli-typescript/pull/1554
  • https://github.com/typed-ember/ember-cli-typescript/pull/1546

Fixes

  • https://github.com/typed-ember/ember-cli-typescript/pull/1560
  • https://github.com/typed-ember/ember-cli-typescript/pull/1563
  • https://github.com/typed-ember/ember-cli-typescript/pull/1538

Dependencies

  • https://github.com/typed-ember/ember-cli-typescript/pull/1542
  • https://github.com/typed-ember/ember-cli-typescript/pull/1545

NullVoxPopuli avatar Oct 10 '23 18:10 NullVoxPopuli

I comment here to avoid opening a new ticket since I've a couple questions that seem vaguely related.

  1. in the ember-cli-typescript documentation I read:

Ember makes heavy use of decorators, and TypeScript does not currently support deriving type information from decorators.

But in reading ts 5.2 release notes I see they've added support for decorator metadata: is that related and meaning that section will be obsolete in time?

  1. I created a new ember typescript project (ember new prj --typescript) with ember-cli 5.3 and this addon is not installed by default: do I need to add it manually?

I apologize in advance if my questions are very dumb since I'm a total newbie in ember.

Polve avatar Oct 20 '23 15:10 Polve

@Polve good questions, but better served by opening a Discussion, so please move there! Thanks!

chriskrycho avatar Oct 21 '23 00:10 chriskrycho

Would it be possible to release the loosened ember-cli-babel version check as a v5 patch rather than as part of the v6 major? Or too much work to split it out for little gain?

I ask because my application has dropped ember-cli-typescript, but I still see the message due to addon dependencies on ember-cli-typescript v5. I imagine those addons are probably not likely to update to v6 and are more likely to drop it instead (as they should). But if they do neither a patch version will mean consumers can at least get rid of the warning message without needing to use overrides/resolutions

Techn1x avatar Nov 15 '23 23:11 Techn1x

I tried just.. getting CI passing.. and it's hard idk what incantations are needed atm. I'd (personally) prefer someone release current main (which already has the ec-babel fix, iirc) without trying to get CI green.

NullVoxPopuli avatar Nov 16 '23 00:11 NullVoxPopuli

Are you able to lend aid @chriskrycho ?

Based on the opening comment, it seems like all the necessary changes have been made, we just need to get releases happening

Techn1x avatar Jan 23 '24 02:01 Techn1x

Also looking for a release here 👀

chasegiunta avatar Feb 29 '24 14:02 chasegiunta