Owen Bickford

Results 34 comments of Owen Bickford
trafficstars

Thank you for the follow up.

I have reproduced this issue on a project which had its `.elixir_ls` directory. With Erlang 26.2.1 & Elixir 1.16.1-otp-26, the LS will also rebuild the directory if it's deleted, so...

@woylie This is a follow up from the [previous discussion](https://github.com/woylie/flop_phoenix/discussions/174#discussioncomment-7117101). I was [reminded](https://twitter.com/clarkware/status/1705263936491356325?utm_source=thinkingelixir&utm_medium=shownotes) that CSS pseudo selectors can be used for this type of scenario, where we can't check a...

Thank you for the feedback, and sorry I didn't see your response earlier. There's a bit more complexity here than I expected, so please forgive the lengthy response below. ##...

I stumbled on the same issue and found a bizarre solution. When I start by using `superfly/[email protected]`, this error occurs. If I use `superfly/fly-pr-review-apps@v1`, the Fly deploy actually triggers a...

@ricksonoliveira If you change the action back to `superfly/[email protected]`, does it deploy successfully? What's weird is that deploys fail unless I start w 1.2.0, change to v1, then change back...

@ricksonoliveira I think this is it: ```yml environment: name: pr-${{ github.event.number }} url: ${{ steps.deploy.outputs.url }} ``` You probably don't have a [GitHub environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment) named `pr-*`. In my repo, I...

This is where I think the example in the readme is possibly wrong, at least based on my understanding of GH environments. Instead of creating an environment for each PR,...

@ricksonoliveira almost! ``` environment: name: staging url: ${{ steps.fly-preview.outputs.url }} ``` Here's my complete `elixir.yml` (look for the `deploy_preview` job): ```yml name: Elixir CI on: push: branches: ["main"] pull_request: branches:...

The short answer is that this repo probably needs some attention. PR #48 has some improvements for managing secrets and some other improvements. Hopefully it will get reviewed soon. Why...