eventsource-android icon indicating copy to clipboard operation
eventsource-android copied to clipboard

add support of http chunks and change EventSource implementation

Open motwingh opened this issue 9 years ago • 4 comments

When server is configured to allow chunked transfer encoding with header Transfer-Encoding: chunked

If response is big enough, it can possibly be sent as HTTP chunks. The current implementation does not handle chunks.

This is a proposal of a chunk handling implementation.

We also changed the EventSource and AsyncEventSourceHandler.

Last thing we used AndroidStudio 2.2 to edit the project and added corresponding configuration files.

Please review for a merge .

motwingh avatar Jul 08 '16 09:07 motwingh

Thanks for the pull request! I'll try to review the code within the next day or two and merge if all looks well.

tylerjroach avatar Jul 08 '16 16:07 tylerjroach

@motwingh I originally threw this project out there without many modifications to a previous library. I noticed that a lot of these commits have a bunch of style changes, as well as code changes. Would you mind if I cleaned up the project a bit, then asked you to submit a new request for the change? I also want to remove the Netty dependency soon in favor of OkHttp, as well as potentially use rxAndroid to improve callback threading, etc. These changes will probably take a bit of time though.

I've noticed that string resources, appCompat lib, and other unnecessary files were also added in some of the commits.

tylerjroach avatar Jul 13 '16 15:07 tylerjroach

Hi, Yes you can cleaned up the project, we will proceed with the new pull request once you've done.

motwingh avatar Jul 19 '16 09:07 motwingh

The repo is in a more stable state now. You can submit the new pull request whenever you get the chance.

tylerjroach avatar Jul 19 '16 15:07 tylerjroach