#9120 improves mail services by making it python3 compatible

[Zectbumo]

Fixes #9120

this makes smtp, pop3, using maildir work and makes the twistd mail tap command work at least with the defaults or basic configuration.

some python 3 tests were enabled and some passed, others still failed. it is a WIP and I am commiting as is since it is useable.

more python3 upgrades are still needed to make fully functional and more py3 tests need to be fixed and enabled.

[glyph]

@Zectbumo Thanks for this contribution. A bit embarrassing that it was necessary, but I hope we can get CI green on this so that we can land and get to the point where the CLI at least works out of the box again 😬

[glyph]

@Zectbumo any chance you could have a look at getting these tests to pass so we can land this fix?

[Zectbumo]

I am getting a "The logs for this run have expired and are no longer available." message so I can't tell if this is something simple or expected to fail. I can do some simple fixes to pass checks but my patch is expected to not pass all tests. The patch I submitted is a better-than-nothing patch since getting to true python 3 compatibility probably requires some overhaul of a component or a big decision to be made. unrelated: this reminds me I also have a python3 compatible txaws patch I need to submit.

[glyph]

I am getting a "The logs for this run have expired and are no longer available." message so I can't tell if this is something simple or expected to fail. I can do some simple fixes to pass checks but my patch is expected to not pass all tests. The patch I submitted is a better-than-nothing patch since getting to true python 3 compatibility probably requires some overhaul of a component or a big decision to be made.

If you can just resolve the conflicts and push something, we can see where we're at; and we can selectively un-skip whatever tests pass now which failed previously, we don't need everything to pass as long as the stuff we expect to pass, passes

[Zectbumo]

Sure, I just need access to the logs. I am getting a "The logs for this run have expired and are no longer available." from github. The only thing I have visibility into is pre-commit.ci "flake8 failed exit code 1" but I have no idea what that is.

[glyph]

Sure, I just need access to the logs. I am getting a "The logs for this run have expired and are no longer available." from github.

Yes, the test run here is too old; the logs have been deleted, github doesn't keep them around forever. Once you've resolved the conflicts, you can merge in trunk, and when you push the branch with trunk merged in, you you'll get a fresh CI run where you can see the logs.

[Zectbumo]

ah, I see. I'm resolving conflicts. I understand now. I'll look into this.

[glyph]

ah, I see. I'm resolving conflicts. I understand now. I'll look into this.

Thanks a bunch!

[codspeed-hq[bot]]

CodSpeed Performance Report

Merging #11898 will not alter performance

_{Comparing Zectbumo:trunk (d50122c) with trunk (49a649b)}

Summary

✅ 16 untouched benchmarks

[Zectbumo]

Okay I was able to sync up to the current trunk and I now see the errors in CI "twisted.internet.error.CannotListenError: Couldn't listen on any:1234: [Errno 98] Address already in use.

twisted.mail.test.test_options.OptionsTests.test_endpointSMTP " How do we move forward here?