ldaptor icon indicating copy to clipboard operation
ldaptor copied to clipboard

avoid duplicating ldaptor code in LDAPServerWithUPNBind

Open graingert opened this issue 5 years ago • 3 comments

Contributor Checklist:

  • [ ] I have updated the release notes at docs/source/NEWS.rst
  • [ ] I have updated the automated tests.
  • [ ] All tests pass on your local dev environment. See CONTRIBUTING.rst.

graingert avatar Feb 18 '20 19:02 graingert

Codecov Report

Merging #161 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   93.35%   93.35%   -0.01%     
==========================================
  Files          72       72              
  Lines        9915     9914       -1     
  Branches      973      972       -1     
==========================================
- Hits         9256     9255       -1     
  Misses        537      537              
  Partials      122      122
Impacted Files Coverage Δ
ldaptor/protocols/ldap/ldapserver.py 80.45% <100%> (-0.07%) :arrow_down:
ldaptor/test/test_server.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c6f5c3...e42ede9. Read the comment docs.

codecov[bot] avatar Feb 18 '20 20:02 codecov[bot]

Thanks for the cleanup. @graingert let us know when you think this is ready for review :)

adiroiban avatar Feb 26 '20 17:02 adiroiban

@adiroiban I think it's ready to go

graingert avatar Feb 26 '20 18:02 graingert