devicePixelRatio is not used in contentPreferencesMode: 'auto'
- [x] I have verified that the issue occurs with the latest twilio-video.js release and is not marked as a known issue in the CHANGELOG.md.
- [x] I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
- [x] I verified that the Quickstart application works in my environment.
- [x] I am not sharing any Personally Identifiable Information (PII) or sensitive account information (API keys, credentials, etc.) when reporting this issue.
Code to reproduce the issue:
contentPreferencesMode: 'auto'
https://github.com/twilio/twilio-video.js/blame/cff4de04be7fa2cdc78909fc102509b1c78c38a6/lib/media/track/remotevideotrack.js#L372-L388
Expected behavior: Element's clientHeight and clientWidth should be multipled by https://developer.mozilla.org/en-US/docs/Web/API/Window/devicePixelRatio
Actual behavior:
This is easy to notice when you resize a video element with contentPreferencesMode: 'auto'. What's happening when you make video element bigger video quality improves greatly, but then you shrink and for about half a second it still looks great, but then it degrades.
Software versions:
- [x] Browser(s): Chrome latest
- [x] Operating System: Mac OS latest
- [x] twilio-video.js: latest
Thank you for reporting this issue @genevpd. Your suggestion makes sense - I have opened an internal ticket for it. (VIDEO-10486) We will take this up soon.
@makarandp0 awesome, thanks so much!
We decided not to pursue this enhancement due to different priorities.