twilio-video.js icon indicating copy to clipboard operation
twilio-video.js copied to clipboard
verified publisher icon twilio

SharedArrayBuffer warning impacting Chrome 91

Open dandoyon opened this issue 4 years ago • 3 comments

Noticing following warning in chrome console, looked at twilio code and it seems innocuous, will it be going away in future version?

SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.

Software versions:

  • [X] Browser(s): Chrome Version 89.0.4389.90 (Official Build) (x86_64)
  • [X] Operating System: MacOs 10.15.7 Catalina
  • [X] twilio-video.js: 2.8.0
  • [X] Third-party libraries (e.g., Angular, React, etc.): AngularJs 1.6

dandoyon avatar Apr 03 '21 16:04 dandoyon

It doesn't seem like twilio-video.js uses SharedArrayBuffer. Recently (with one of Chrome updates) this error started appearing in all React versions (all but the most recent one, 17.0.2, which fixed this issue).

On React 17.0.2 and twilio-video 2.8.0-beta-3 and warning doesn't appear.

It may be connected to AngularJs 1.6, or other packages you may use.

MonstraG avatar Apr 07 '21 08:04 MonstraG

I haven't tried upgrading to the latest version of twilio-video.js but a quick search in the distributed file shows instances of SharedArrayBuffer. I'll report back once I've tried upgrading the library.

Edit: definitely an issue in Twilio library

Screen Shot 2021-05-04 at 3 47 02 PM

http-teapot avatar May 04 '21 22:05 http-teapot

@dandoyon , @http-teapot ,

Thanks for the investigation. I dug a bit deeper and traced it to our dependency on Browserify's node-util module. The upcoming 0.12.4 release should fix the problem.

Thanks,

Manjesh

manjeshbhargav avatar May 11 '21 00:05 manjeshbhargav