twilio-conversations-demo-ios-swift icon indicating copy to clipboard operation
twilio-conversations-demo-ios-swift copied to clipboard

Published 20 hours ago • verified publisher icon twilio

Cleaned up variable name and comments

Open segheysens opened this issue 3 years ago • 5 comments

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

segheysens avatar Aug 11 '22 21:08 segheysens

@segheysens hi, could you please address the review comments?

berkus avatar Sep 01 '22 11:09 berkus

@berkus made these updates!

segheysens avatar Oct 05 '22 17:10 segheysens

@segheysens hi! Please address the remaining notes and I believe the observableTypingParticipantList rename is not finished - there are still old names in a few places below. Please double check by compiling the app!

berkus avatar Oct 06 '22 08:10 berkus

@segheysens hi, do you plan to finish up this PR?

berkus avatar Dec 05 '22 10:12 berkus

@segheysens gentle poke!

berkus avatar Sep 28 '23 06:09 berkus