plugin-rtc icon indicating copy to clipboard operation
plugin-rtc copied to clipboard

feat: Cli core upgrade

Open shrutiburman opened this issue 3 years ago • 1 comments

Contributing to TwilioReasons to remove some e2e testcases: Removed some tests because:

  • These testcases were deploying a new video app with actual api keys & secrets configured on circleci. It's unclear which account's creds are those. Also, second guessing the process of storing the secrets anywhere.
  • The existing testing suite of deploying apps yields a 404 error from serverless api. Failed Pipeline run

Current coverage report: image

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

shrutiburman avatar Oct 12 '22 17:10 shrutiburman

We, SDK team attempted to review this PR but we do not have expertise on the codebase. So, we cannot give any meaningful feedbacks.

piyushtank avatar Oct 13 '22 22:10 piyushtank