twenty icon indicating copy to clipboard operation
twenty copied to clipboard

Published 20 hours ago • verified publisher icon twentyhq

Implement <ScrollRestoration />

Open FelixMalfait opened this issue 1 year ago • 6 comments

Current behavior

As of today, when you hit the "back" button, you are always redirected to the top of the page. This is annoying when working with lots of records (e.g. Kanban board).

https://github.com/twentyhq/twenty/assets/6399865/7a9c71f4-0f23-437c-b2bd-5ba4c6253757

Desired behavior

Other websites like Github just record the scroll position. This seems to be doable with https://reactrouter.com/en/main/components/scroll-restoration#scrollrestoration-

Edit: also check https://reactrouter.com/en/main/components/link#preventscrollreset not sure if needed

FelixMalfait avatar Mar 07 '24 11:03 FelixMalfait

@FelixMalfait Could I be assigned this? Thanks

Jonathanlemon avatar Mar 26 '24 20:03 Jonathanlemon

@Jonathanlemon of course, that'd be very helpful if you can solve this. Got this feedback twice from users. Thanks!

FelixMalfait avatar Mar 27 '24 07:03 FelixMalfait

@Jonathanlemon did you have time to look yet? Thanks!

FelixMalfait avatar Apr 15 '24 16:04 FelixMalfait

@FelixMalfait Something came up where I will not be able to look into this, sorry. Please unassign me

Jonathanlemon avatar Apr 15 '24 21:04 Jonathanlemon

OK no problem @Jonathanlemon thanks for trying!

FelixMalfait avatar Apr 17 '24 11:04 FelixMalfait

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-4357

gitstart-app[bot] avatar Apr 17 '24 11:04 gitstart-app[bot]