flask-secure-headers icon indicating copy to clipboard operation
flask-secure-headers copied to clipboard

Published 20 hours ago • verified publisher icon twaldear

Py3 compat + other fixes

Open tarekziade opened this issue 8 years ago • 5 comments

Thanks for the lib, I am planning to use it on a python 3 project.

If you are interested in my changes:

  • python 3 support
  • some cleanups
  • started to fix some tests.

My next step is to make it pass the flake8 standard and finish fixing the tests, if you are interested in this contribution. Cheers!

tarekziade avatar Aug 31 '17 20:08 tarekziade

are the changes complete?

twaldear avatar Sep 20 '17 23:09 twaldear

would love to use this as well for py3. @tarekziade anything I can do to help?

jeffbryner avatar Nov 20 '18 21:11 jeffbryner

Hey @jeffbryner - sorry I dropped that work. I guess my branch would need to be refreshed with the latest Flask and should work, if you are interested in picking up the work. Full disclosure: I am not involved right now in any Flask-based project

tarekziade avatar Nov 20 '18 21:11 tarekziade

No worries, I took a shot at it as well using 2to3 then trying to correct the tests but honestly I couldn't figure out why some of the tests were failing. There's some magic going on with the header ordering that I couldn't figure out.

I pivoted to manually setting headers. Hopefully someone else will have better luck.

jeffbryner avatar Dec 12 '18 02:12 jeffbryner

@twaldear - Are you in chat with others on this pr?

gaurabb avatar Aug 01 '19 22:08 gaurabb