django-schemata icon indicating copy to clipboard operation
django-schemata copied to clipboard

added Database var

Open slafs opened this issue 12 years ago • 3 comments

As of Django 1.4 there's a Database var in base.py in backends. Some apps can rely on this. In Django 1.6 BinaryField also relies on this.

sorry for some extra commits

slafs avatar Aug 07 '13 10:08 slafs

Hey Sławomir, I just notices you pull request. Thanks for it.

Why is there a try: except: needed? Wouldn't Database = original_backend.Database be enough? It appears that since Django 1.1, the Database name is present in backend base modules for postgresql_psycopg2 and oracle.

tuttle avatar Sep 20 '13 13:09 tuttle

Is it? OK. Than we can ignore it. Actually this is unfinished because we should copy all the global vars from the original backend.

slafs avatar Sep 20 '13 14:09 slafs

I agree. BTW, I'm glad my project got your interest. I'm no longer working on it (reasons can be found in other Issues here).

If you are actively building something upon schemata, may I ask you to develop and test the "import *" from original backend? I believe inheriting the DatabaseWrapper can be done by renaming the original DatabaseWrapper to temporary name.

tuttle avatar Sep 20 '13 14:09 tuttle