polymer-redux icon indicating copy to clipboard operation
polymer-redux copied to clipboard

Cannot read property 'Path' of undefined

Open moebiusmania opened this issue 8 years ago • 4 comments

I'm upgrading 1.x elements with polymer-redux 0.4.2 to 2.x/3.x element syntax and polymer-redux 1.0.2, following the docs it's all going fine, but the statePath attribute to properties throws the error in the title. During the refactor the store has remained unchanged and updates on event dispatching.

Someone has any ideas?

moebiusmania avatar Aug 30 '17 10:08 moebiusmania

got it, since I'm working with Polymer 3.0-preview branch there is no global Polymer object and this line https://github.com/tur-nr/polymer-redux/blob/master/src/index.js#L62 breaks.

I will adapt the code to ES modules and if it works correctly I'll send you a PR so maybe you can create a 3.0 preview branch too 😄

moebiusmania avatar Aug 30 '17 12:08 moebiusmania

Looking forward to the PR, Thanks!

On Wed, 30 Aug 2017 at 22:30, Salvatore Laisa [email protected] wrote:

got it, since I'm working with Polymer 3.0-preview branch there is no global Polymer object and this line https://github.com/tur-nr/polymer-redux/blob/master/src/index.js#L62 breaks.

I will adapt the code to ES modules and if it works correctly I'll send you a PR so maybe you can create a 3.0 preview branch too 😄

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tur-nr/polymer-redux/issues/97#issuecomment-325975632, or mute the thread https://github.com/notifications/unsubscribe-auth/AAx37k6e7gpIl68DpcVfyt-ZvfK9Jfbuks5sdVX5gaJpZM4PHNL0 .

tur-nr avatar Aug 30 '17 12:08 tur-nr

@tur-nr fixed! I'm doing the PR but I see you only have master branch, PR there anyway or you want to create a preview branch where I can PR to?

moebiusmania avatar Aug 30 '17 12:08 moebiusmania

for me, changing the line

Polymer.Path.get(state, statePath);

to

window.Polymer.Path.get(state, statePath);

make it work

ralexrdz avatar Nov 13 '17 20:11 ralexrdz