Barry Pollard

Should be a simple matter of overriding `class FromExpressionElementSegment` in the dialect_clickhouse.py file and adding `Ref.keyword("Final", optional=True),` after `OptionallyBracketed(Ref("TableExpressionSegment")),` and then adding a test case as detailed in [Contributing Dialect...

Related to #2634

Sorry missed this earlier. I'm not the most familiar with rule L003 but do know it's one of the more complicated (if not the most complicated!) ones. @barrywhart any thoughts...

While it arguably might not technically be a function, is there any reason not to treat it as such for rule L017? Is it better to have no spaces here...

OK and don't disagree there is more to do here for that unparsable section. My question is more related to the original issue raised - in your opinion should L017...

> In this query, an L054 (Inconsistent column references in 'GROUP BY/ORDER BY' clauses.) is detected at the `order by` within the `array_agg` window function on line 4, even though...

L054 already skips enforcing this role in windowing functions as noted in the docs: https://docs.sqlfluff.com/en/stable/rules.html#sqlfluff.core.rules.Rule_L054 This is done for precisely the reasons you note. The issue here is an array...

I think our plugin documentation could be greatly improved. Not done any myself (and I'm a little intimidated to start even though I'm a maintainer here!) because of this. So...

I believe this is a duplicate of #3544 rather than #2845

So there's three issues here: 1. Spaces before the signed are not currently accepted by SQLFluff 2. Multiple signs are not accepted by SQLFluff 3. There is no rule to...