plugin-responsive-images icon indicating copy to clipboard operation
plugin-responsive-images copied to clipboard
verified publisher icon ttc-freebies

Custom Sizes Attribute is missing in Output

Open Der-Lizzard opened this issue 2 years ago • 3 comments

Joomla 4.3.3 and PHP 8.1

Tested with plugin versions 4.2.6 and the latest 4.2.7.

In Frontend, the custom sizes attribute is missing.

If you remove the commented out array_push in line 248 (file: \libraries\Ttc\src\Freebies\Responsive\Helper.php), the custom sizes attribute is shown in frontend.

With commented out without

Removed commented out with

Der-Lizzard avatar Nov 27 '23 15:11 Der-Lizzard

Pls are welcome, although:

  • the sizes would be nice to be user driven (or derived from the breakpoints, the commented code is hardcoded to the default values)
  • the sizes are optional (https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images)

dgrammatiko avatar Nov 29 '23 12:11 dgrammatiko

Yes, i know - the sizes are optional - but if there is a field for sizes in the plugin-config, i thought i can use it ;-)

Der-Lizzard avatar Nov 30 '23 10:11 Der-Lizzard

Turns out that I never implemented that feature, the field exists but it's not really used. I will try to publish an update when I get some free time.

Thanks

dgrammatiko avatar Dec 04 '23 21:12 dgrammatiko