platforms icon indicating copy to clipboard operation
platforms copied to clipboard

Published 20 hours ago • verified publisher icon tsuru

Add Rust platform

Open scorphus opened this issue 9 years ago • 4 comments
trafficstars

  • [x] Add basic platform support
  • [x] Support code deployment
  • [x] Support customized code deployment
  • [x] Allow choosing Rust distribution: nightly, beta or stable
  • [ ] Support binary deployment
  • [ ] Add tests

scorphus avatar Jul 08 '16 23:07 scorphus

@bltavares

ayr-ton avatar Oct 09 '18 04:10 ayr-ton

Hello @scorphus. How's the current status of this? I think it's looking really nice, and I'd love to see Tsuru offering a default Rust platform.

I believe if we remove the rust-docs, it could greatly reduce the base rust platform image size. Also, I believe it should be more strict with which toolchains are allowed, using the .rust-toolchain file.

I'd like to know if you're still interested in finishing it, or do you want to pass ahead this issue.

jonnyguio avatar Dec 01 '18 16:12 jonnyguio

Hey, @jonnyguio! I'm glad this issue caught your attention! I tried to give it some traction by adding the hacktoberfest label two years ago, but nothing much happened.

That's great, I'll be very happy seeing it solved! A lot has changed in Rust since then and I like your suggestions. I've updated the initial commit, mostly to remove the “WIP” part. So please feel free to work on top of it ‒ just please remember to keep it as is.

What do you think if I open a pull request with the existing code and we both work on it ‒ code/review?

scorphus avatar Dec 02 '18 21:12 scorphus

Hey, @scorphus. Thanks for the quick reply!

I'm really glad to hear that! I believe that opening the pull request is a great idea, so we can both work on it. You're right, a lot has change since two years ago, and the debut of the 2018 version is very close now. So, I think it's about time to address this issue.

After seeing your code (and also do some myself), I started wondering about the following questions:

  • How to offer the Rust Platform. By choosing the toolchain? Choosing the version (Rust 2015, Rust 2018)?
  • Which components of Rust it should be installed?
  • How the Rust code should be compiled and installed in each deploy?

The last one is more about how to follow the default organization of Tsuru, to be consistent with the other languages (for example, the executable should be in /home/application/current).

What are your opinions? Feel free to answer it here or in the future PR.

jonnyguio avatar Dec 03 '18 16:12 jonnyguio