cm icon indicating copy to clipboard operation
cm copied to clipboard

key map not saved when quitting from within the key map editor

Open FrankGrimm opened this issue 5 years ago • 1 comments

When editing a key binding and pressing action::QUITthe update is not saved to the configuration file.

Steps to reproduce:

  1. Open cm
  2. press K (action::OPEN_KEY_MAP_SETTINGS) to open the key editor
  3. Add or delete a key binding
  4. Press q (action::QUIT) immediately without going back to the key list with action::BACK_DELETE.

Result: The added or deleted key bindings are not reflected in the config file.

Expectation: Since I can move around the right hand side of the list in that state (e.g. select and delete the old binding of a key) I would expect my changes to be stored when exiting the program at that point.

Sidenote: I just realized that action::CANCEL is a thing for the ItemLists and this might be expected behavior. Feel free to close the issue if that's the case.

FrankGrimm avatar Sep 29 '20 11:09 FrankGrimm

Sidenote: I just realized that action::CANCEL is a thing for the ItemLists and this might be expected behavior. Feel free to close the issue if that's the case.

It is the case, but that means the system is not intuitive enough. I'll keep it open to remind me to look into that later. Thank you very much for reporting this!

rexim avatar Sep 29 '20 18:09 rexim