Tyler Mathis

Results 40 comments of Tyler Mathis

okay, since this isn't an _error_ in emmet/the run_type enums I am going to move this to a discussion

closing this out as of #1167, and [0.84.6rc3](https://github.com/materialsproject/emmet/releases/tag/v0.84.6rc3) Thanks Aaron!

some notes: ~~1. depends on #1021~~ ~~2. could supersede #974~~ ~~3. this will need to be addressed for the progress bar to be accurate in the case were `has_gnome_access=False`:~~ https://github.com/materialsproject/api/blob/aee0f8c117e01e514604b4c5996f144a4c3b560d/mp_api/client/core/client.py#L573-L579...

ah and based on the failing test for trajectories, I assumed returning the pymatgen object was correct, should the `dict` be returned? @esoteric-ephemera https://github.com/materialsproject/api/blob/aee0f8c117e01e514604b4c5996f144a4c3b560d/mp_api/client/routes/materials/tasks.py#L57

> For the AlphaID, to handle either the no prefix/separator ("aaaaaaft") and with prefix/separator ("mp-aaaaaaft") cases, both of these should work, but I can also just save the "padded identifier"...

good catches @tschaume you're obviously free to keep adding changes for testing, but you can also just ping me if you want me to update things as changes come in...

and FYI, tests are mostly good locally with my endpoint set to preview. these two fail regardless once the env gets reset during testing: ```shell FAILED tests/test_mprester.py::TestMPRester::test_get_api_key_endpoint_from_env_var - KeyError: 'access_controlled_batch_ids'...

I think for the core tasks collection we're going prefix-less, correct? All the others will get prefixes at parse/build time.

re: the iterating, indexing into the local dataset, etc I am a little conflicted on what the best route for the python-like implementation/behavior of the local `MPDataset`s should be. Mainly...