node-mysql-utilities Fix upsert logic in check count

Fix upsert logic in check count

Open ryoheinagao opened this issue 3 years ago • 2 comments

trafficstars

I found and fix that count has string type, so below line is always false.

https://github.com/tshemsedinov/node-mysql-utilities/blob/e829aa19d76ccf81e451f7420322f60b423650d2/utilities.js#L400

[ ] tests and linter show no problems (npm t)
- Please tell me how to run test locally.
[ ] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)

Jun 06 '22 11:06 ryoheinagao

Thank you for your quick review. Do I have to do anything else for merge and release?

Jun 07 '22 02:06 ryoheinagao

@tshemsedinov Can you tell me below?

Thank you for your quick review. Do I have to do anything else for merge and release?

Jun 20 '22 10:06 ryoheinagao