OpenDMARC icon indicating copy to clipboard operation
OpenDMARC copied to clipboard

Feature request: Add option to customize reject string

Open tomsommer opened this issue 5 years ago • 5 comments

It would be nice to be able to configure the reject string.

See https://github.com/flinkflonk/opendmarc-unafraid-hacked/commit/ae88ea0da30f939ac31db487c7dba7d603425046 for inspiration.

tomsommer avatar Oct 20 '20 08:10 tomsommer

Hey Tom,

I'm the port maintainer for FreeBSD's opendmarc build, and this looks like a solid addition. Could you see if flinkflonk could turn this into a pull request that can be used here? (Assuming the maintainers don't pull it in here, I could conceivably use it in the BSD port instead).

thegushi avatar Mar 08 '21 08:03 thegushi

I'd like to see this as a PR so that we can fold it into the develop branch. Can you submit a PR @tomsommer? I'll link it to this issue, and we can properly run through a quick test cycle and add it in.

-Martin

martinbogo avatar Mar 11 '21 18:03 martinbogo

we have our pull request. Still needs review, but in theory this can be closed (if we accept the pull, it's closed. If we reject it, it's wontfix :) )

thegushi avatar Mar 11 '21 19:03 thegushi

Retargeting this for the 1.5.0 branch.

thegushi avatar Mar 19 '21 04:03 thegushi

Fixed the pull request (had a conflict with a feature I didn't have in my repo).

flinkflonk avatar Apr 22 '21 11:04 flinkflonk