OpenDKIM icon indicating copy to clipboard operation
OpenDKIM copied to clipboard

Published 20 hours ago • verified publisher icon trusteddomainproject

Lua odkim.del_header function ignores header number

Open branciar opened this issue 1 year ago • 5 comments

The odkim.del_header(ctx, name, n) function offered for use in Lua final script is broken: it always deletes the first instance of the provided header instead of the nth one.

The attached patch is a fix proposal. opendkim_dkimf_xs_delheader_patch.txt

branciar avatar Dec 01 '23 17:12 branciar

I'm interested in the issue because I'v used Lua script in setup. However your patch cannot be gotten from Github. Could you make a PR address it, or gist for the patch, or something that those who is interested in it can see?

futatuki avatar Mar 13 '24 07:03 futatuki

... However your patch cannot be gotten from Github. ...

Ah, it was temorary error, and I could get the patch.

futatuki avatar Mar 14 '24 10:03 futatuki

I conformed it. I think you are right.

futatuki avatar Mar 14 '24 11:03 futatuki

I made PR #206 for going ahead.

futatuki avatar Mar 14 '24 15:03 futatuki

@branciar If you will make a PR address this issue by yourself, I'll close PR #191.

futatuki avatar Apr 03 '24 16:04 futatuki