OpenDKIM icon indicating copy to clipboard operation
OpenDKIM copied to clipboard

Use a functional test for OpenSSL ed25519 support

Open ghen2 opened this issue 3 years ago • 5 comments

rather than a hardcoded openssl version check, for openssl 3.0+ compatibility.

ghen2 avatar Dec 20 '21 14:12 ghen2

this PR solve the same problem as my PR #193 in exactly the same way.

One of the PR's is obsolete

andreasschulze avatar Dec 11 '23 17:12 andreasschulze

They're not identical, mine takes into account older openssl versions not supporting genpkey (but returning 0).

ghen2 avatar Dec 16 '23 10:12 ghen2

Sorry, looking at your and my Version, I really see no relevant difference.

What do I miss?

andreasschulze avatar Dec 18 '23 15:12 andreasschulze

You overlooked my second commit https://github.com/trusteddomainproject/OpenDKIM/pull/135/commits/ce8a278f9708714fceb016e97859439417cf119d.

ghen2 avatar Dec 18 '23 16:12 ghen2

Ah, thanks, this is indeed something I wasnt's aware. So: let's take your version ...

andreasschulze avatar Dec 18 '23 19:12 andreasschulze