Not compiling with Ruby Sass

[knirb]

I had an issue with the arg --no-source-map since I had Ruby sass (v 3.7.4) installed which uses --sourcemap=none instead.

I fixed it by simply uninstalling Ruby sass.

I cloned the repo but don't feel comfortable enough with the code-base to contribute, but the option is being set at line 78 in sass.rs.

I would Imagine a fix would consist of either forcing the use of dart-sass, alternatively to add an exception for Ruby Sass.

Hope this is helpful in any way, and sorry for not being able to contribute with a PR. Very new to Rust.

[simbleau]

Thanks for actually diagnosing the issue, I realize that #413 is related.

You are correct that uninstalling Ruby works, because Dart Sass will be installed by Trunk.

In the future we can check if Ruby is installed and make adjustments to the installation.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 5 days with no activity.

[ydirson]

Any progress on this issue?

[ctron]

Any progress on this issue?

Not really. I think the best way to move forward if you need support for ruby sass would be a PR, which adds support for this. Not sure how this would work in combinations with other sass implementations. Maybe you have a good idea?

[ydirson]

As I understand it, when there is no sass available , trunk will fetch another implementation, right? Isn't it possible to just do the same even if there is another sass installed?

[ctron]

Technically yes … but simply fetching a new tool because of a version mismatch might also be a bit problematic.

Trunk would need to figure out that it is not only a different version, but also a different kind of sass. And only then fetch its expected type.

But, if we figure out that it's a different kind of sass, then why not simply support it? (unless there's a technical reason not to)

[ydirson]

It's not like it's a tool expected to be found on every box trunk runs on. I only had it installed because of spooky/fishy package dependencies, likely surrounding Jekyll. (well the package description advertises it as deprecated, so maybe the problem is on its way out already, but Debian 11 is not EOL yet)