[BUG] Trunk Reloads Webpage on Build Fail

[anlumo]

The new auto-reload feature is very nice, but unfortunately it also reloads my web page when the build failed, loading the old version.

I've spent a lot of time wondering why my change didn't change the behavior of the application when it just kept reloading the old one, with the build errors being shown in a hidden background window.

It'd be great if trunk would not reload the page when the error occurs, or ideally show an error page with the build messages.

[thedodd]

@anlumo hey there. This is related to some efforts taking place here:

• https://github.com/thedodd/trunk/issues/141
• https://github.com/thedodd/trunk/pull/237

Ultimately we want to communicate this info as an error overlay. I was actually thinking that we would not reload on errors. Perhaps our autoloader script needs to be updated. I'll take a look.

[thedodd]

Yea, looks like we are just passing along a hard coded value to trigger the reload. We can definitely update this to actually evaluate the success or failure state of the build.

[lilyball]

This issue is really annoying for me. Every time I have a build failure I get confused because the page reloads and I forget to check the console to make sure it worked. An error overlay is a neat idea but I really just want it to not reload the page unless the build succeeded.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 5 days with no activity.