trunk icon indicating copy to clipboard operation
trunk copied to clipboard

Trunk docker image

Open tonda100 opened this issue 4 years ago • 3 comments

Provide official docker image for building source code via Trunk.

tonda100 avatar Jul 31 '21 20:07 tonda100

Not a bad idea. If we do this, we will need to inherit from the base Rust images, as Rustc & Cargo are still required.

@tonda100 do you see this as being more valuable than just providing easy CI integration for installing the Trunk binaries? My primary concern is that we would need to introduce a pretty heft build matrix for all of the different base images we would need to provide. Perhaps it would be sufficient to provide only :slim-based images.

What do you think about: https://github.com/thedodd/trunk/issues/200

thedodd avatar Aug 02 '21 17:08 thedodd

I think we should start small with slim-based images and we can provide more later if it will be necessary. Trunk binaries are good but you have to install them with every build or you need bigger setup with own build workers, small projects usually cannot affort that. I prefer docker build images whenever possible. I have tried to create one on ubuntu because official Rust image are pretty big but anyway it is still almost 500MB. https://github.com/osomahe/rust-trunk and https://hub.docker.com/repository/docker/osomahe/rust-trunk

tonda100 avatar Aug 03 '21 04:08 tonda100

About the CI integration: I use Drone CI (both at work and for side projects), and a core concept that makes it really powerful is that at least for the default docker pipelines, everything is run in a docker container and every single pipeline step can use a different image: https://docs.drone.io/pipeline/docker/syntax/images/ So for me, easy CI integration and docker images are basically the same thing.

I'm currently looking into building an alpine-based trunk image, but I realized now that the alpine images are usually bigger than the slim ones - I do wonder why. I have a minimal trunk image uploaded, but I apparently can't see its compressed size yet.

Follpvosten avatar Aug 03 '21 17:08 Follpvosten

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Nov 14 '23 00:11 github-actions[bot]

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Nov 19 '23 00:11 github-actions[bot]