trunk icon indicating copy to clipboard operation
trunk copied to clipboard

Published 20 hours ago • verified publisher icon trunk-rs

[watch] allow ignoring non-existing paths

Open Gentle opened this issue 4 years ago • 2 comments

Checklist

  • [x] Updated CHANGELOG.md describing pertinent changes.
  • [x] Updated README.md with pertinent info (may not always apply).
  • [x] Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will :).

Gentle avatar Apr 30 '21 13:04 Gentle

Looks like some tests need to be updated.

thedodd avatar May 17 '21 02:05 thedodd

Stale? Do we still want this? If so, I can fork this and try to fix the tests.

nuzzles avatar Jul 23 '22 17:07 nuzzles

@simbleau yea, I would actually really like to include these changes, but I think it needs to be updated, rebased, and instead of filtering on .exists(), we should filter on .try_exists() and handle/log error conditions (permissions, invalid symlink, &c) instead of silently ignoring.

Are you interested in doing an update PR on this? Or @Gentle if you are still around, feel free to update accordingly. If you do update, please re-open a new PR!

Thank you for your patience.

thedodd avatar Jul 07 '23 16:07 thedodd