charts icon indicating copy to clipboard operation
charts copied to clipboard

fix(vikunja) Update vikunja to last version

Open yodatak opened this issue 1 year ago • 6 comments

Description Remove and rename unncesseray container ⚒️ Fixes #

⚙️ Type of change

  • [ X] 🪛 Bugfix
  • [ X] 🔃 Refactor of current code

🧪 How Has This Been Tested? On upgrading my existing vikunja cluste ✔️ Checklist:

  • [X ] ⚖️ My code follows the style guidelines of this project
  • [X ] 👀 I have performed a self-review of my own code
  • [ X] #️⃣ I have commented my code, particularly in hard-to-understand areas
  • [ X] 📄 I have made corresponding changes to the documentation
  • [ X] ⚠️ My changes generate no new warnings
  • [ X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • [X ] ⬆️ I increased versions for any altered app according to semantic versioning
  • [ X] I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

yodatak avatar Aug 28 '24 17:08 yodatak

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 28 '24 17:08 CLAassistant

Im curious:

  • Where did you make any comments as you marked it?
  • Which documentation changes did you make?
  • Where are those tests you ticked off?
  • Where is the version increase?

Dont mark stuff you havent done! Not everything is needed

alfi0812 avatar Aug 28 '24 17:08 alfi0812

Need to bump the version in chart.yaml And as its a new image and different make it major.

alfi0812 avatar Aug 28 '24 17:08 alfi0812

Thanks for you review ! Shoud i bump dependincies command and redis too ?

yodatak avatar Aug 29 '24 12:08 yodatak

Thanks for you review ! Shoud i bump dependincies command and redis too ?

The dependencies get auto-updated by renovate. But can do if you want.

alfi0812 avatar Aug 29 '24 12:08 alfi0812

The values.yaml currently isnt valid.

alfi0812 avatar Aug 29 '24 12:08 alfi0812

@all-contributors please add @yodatak for code

alfi0812 avatar Aug 31 '24 10:08 alfi0812

@alfi0812

I've put up a pull request to add @yodatak! :tada:

allcontributors[bot] avatar Aug 31 '24 10:08 allcontributors[bot]

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

truecharts-admin avatar Nov 26 '25 00:11 truecharts-admin