charts icon indicating copy to clipboard operation
charts copied to clipboard

fix(crafty-4): Update values.yaml

Open lucasyoboy opened this issue 1 year ago • 2 comments

Changed https to http

Description Bad protocol. ⚒️ Fixes #

⚙️ Type of change

  • [ ] ⚙️ Feature/App addition
  • [x] 🪛 Bugfix
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • [x] ⚖️ My code follows the style guidelines of this project
  • [x] 👀 I have performed a self-review of my own code
  • [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas
  • [ ] 📄 I have made corresponding changes to the documentation
  • [ ] ⚠️ My changes generate no new warnings
  • [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • [ ] ⬆️ I increased versions for any altered app according to semantic versioning
  • [x] I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • [ ] 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance.

lucasyoboy avatar Jun 15 '24 22:06 lucasyoboy

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 15 '24 22:06 CLAassistant

I was working with a Cloudflare tunnel, but for some reason, Cloudflare refused to accept the HTTPS certificate. So, I attempted to use the HTTP port, but the protocol wasn't correct.

lucasyoboy avatar Jun 15 '24 22:06 lucasyoboy

I was working with a Cloudflare tunnel, but for some reason, Cloudflare refused to accept the HTTPS certificate. So, I attempted to use the HTTP port, but the protocol wasn't correct.

Thats not a good reason, does it work locally or not? We don't care about whatever services you put in front of it, besides ingress.

Generally for https ingress should always be used.

PrivatePuffin avatar Jul 19 '24 08:07 PrivatePuffin

Seems to work fine for me with https. Closing

alfi0812 avatar Jul 24 '24 15:07 alfi0812